Correct type of ref in forwardRef render()#13100
Merged
bvaughn merged 1 commit intofacebook:masterfrom Jul 11, 2018
motiz88:patch-1
Merged
Correct type of ref in forwardRef render()#13100bvaughn merged 1 commit intofacebook:masterfrom motiz88:patch-1
ref in forwardRef render()#13100bvaughn merged 1 commit intofacebook:masterfrom
motiz88:patch-1
Conversation
`React$ElementRef<T>` is the type of the ref _instance_ for a component of type T, whereas `React$Ref<T>` is the type of the ref _prop_ for a component of type T, which seems to be the intended type here.
icarlossz
approved these changes
Jun 26, 2018
bvaughn
approved these changes
Jul 11, 2018
Contributor
bvaughn
left a comment
bvaughn
left a comment
There was a problem hiding this comment.
This looks correct 👍 Thank you
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
React$ElementRef<T>is the type of the ref instance for a component of typeT, whereasReact$Ref<T>is the type of the ref prop for a component of typeT, which seems to be the intended type here.As a side note,
React$Ref<T>also encompasses string refs, which (unsurprisingly) don't seem to actually work withforwardRef. Not sure if we care that much, because presumably refs are intended to be pretty opaque in this context?